CFM-31_Enrollment_Flows_enable_people_picker_for_self_service #324
+140
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
deleted the
CFM-31_Enrollment_Flows_enable_people_picker_for_self_service
branch
Ioannis
restored the
CFM-31_Enrollment_Flows_enable_people_picker_for_self_service
branch
Ioannis
force-pushed
the
CFM-31_Enrollment_Flows_enable_people_picker_for_self_service
branch
from
ada4095
to
22163b4
Compare
Ioannis
force-pushed
the
CFM-31_Enrollment_Flows_enable_people_picker_for_self_service
branch
from
22163b4
to
f2c2a63
Compare
benno
reviewed
Sep 2, 2025
| @@ -661,6 +661,7 @@ | |||
| "plugin": {}, | |||
| "ordr": {}, | |||
| "actor_type": { "type": "string", "size": 2 }, | |||
| "enable_person_find": { "type": "boolean" }, | |||
There was a problem hiding this comment.
I know on the dev call we decided to move this configuration to EnrollmentFlowStep, but on further reflection I wonder if it should actually be specific to the AttributeCollector? I don't think any other plugin is likely to use this setting...
| msgstr "Enable People Picker for Self Service" | ||
|
|
||
| msgid "EnrollmentFlowSteps.enable_person_find.desc" | ||
| msgstr "Enable people picker for self-service enrollments, see <a href=\"https://spaces.at.internet2.edu/display/COmanage/COmanage+Registry+PE+Technical+Manual\">Registry Technical Manual</a> for privacy considerations" |
There was a problem hiding this comment.
We'll need a deep link to the specific page (and preferably anchor) with the discussion of privacy consideration. This probably belongs in the Attribute Collector documentation.
Comment on lines
-99
to
+124
| print $this->element('form/listItem', [ | ||
| 'arguments' => [ | ||
| 'fieldName' => 'person_picker_display_fields', | ||
| 'labelIsTextOnly' => true, | ||
| 'groupedControls' => [ | ||
| // each key is the fieldName of the control we are going to create | ||
| 'person_picker_email_address_type_id' => [ | ||
| 'fieldOptions' => [ | ||
| 'label' => __d('field', 'mail'), | ||
| 'empty' => '(' . __d('operation', 'all') . ')', | ||
| // 'all' => '(' . __d('operation', 'all') . ')' | ||
| ], | ||
| ], | ||
| 'person_picker_identifier_type_id' => [ | ||
| 'fieldOptions' => [ | ||
| 'label' => __d('field', 'identifier'), | ||
| 'empty' => '(' . __d('operation', 'all') . ')', | ||
| // 'all' => '(' . __d('operation', 'all') . ')', | ||
| ], | ||
| ], | ||
| 'person_picker_display_types' => [ | ||
| 'singleRowItem' => true, | ||
| 'fieldLabel' => __d('field', 'CoSettings.person_picker_display_types') | ||
| ] | ||
| ], | ||
| ]]); | ||
| // print $this->element('form/listItem', [ | ||
| // 'arguments' => [ | ||
| // 'fieldName' => 'person_picker_display_fields', | ||
| // 'labelIsTextOnly' => true, | ||
| // 'groupedControls' => [ | ||
| // // each key is the fieldName of the control we are going to create | ||
| // 'person_picker_email_address_type_id' => [ | ||
| // 'fieldOptions' => [ | ||
| // 'label' => __d('field', 'mail'), | ||
| // 'empty' => '(' . __d('operation', 'all') . ')', | ||
| //// 'all' => '(' . __d('operation', 'all') . ')' | ||
| // ], | ||
| // ], | ||
| // 'person_picker_identifier_type_id' => [ | ||
| // 'fieldOptions' => [ | ||
| // 'label' => __d('field', 'identifier'), | ||
| // 'empty' => '(' . __d('operation', 'all') . ')', | ||
| //// 'all' => '(' . __d('operation', 'all') . ')', | ||
| // ], | ||
| // ], | ||
| // 'person_picker_display_types' => [ | ||
| // 'singleRowItem' => true, | ||
| // 'fieldLabel' => __d('field', 'CoSettings.person_picker_display_types') | ||
| // ] | ||
| // ], | ||
| // ]]); |
There was a problem hiding this comment.
Are we removing these configurations from CO Settings? If so, we should remove them from schema.json and the model code as well.
There was a problem hiding this comment.
I think we are. I will make the extra changes.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.